Improve internal GitLab CI #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedIsmail02
force-pushed
the
improve-internal-gitlab-ci
branch
3 times, most recently
from
d3255c9 to
bb37730
Compare
hugueskamba
approved these changes
Nov 2, 2023
AhmedIsmail02
force-pushed
the
improve-internal-gitlab-ci
branch
from
bb37730 to
3f75495
Compare
urutva
previously approved these changes
Nov 2, 2023
- Hardcoded inputs are replaced by configruable parameters to allow using the same code for building multiple applications on different targets without the need to duplicate codes. - Fix S3 bucket emptying in cleanup where the script can now be used to clean up all resources as opposed to just the resources associated with the aws-iot-example application. Signed-off-by: Ahmed Ismail <[email protected]>
Blinky example is now added to be built and run by the internal GitLab CI where the output of the execution of the application on FVP is compared to the expected printed statements. Signed-off-by: Ahmed Ismail <[email protected]>
This matches the dependency project name. Signed-off-by: Hugues Kamba-Mpiana <[email protected]>
AhmedIsmail02
force-pushed
the
improve-internal-gitlab-ci
branch
from
3f75495 to
3287623
Compare
Quality check stage is added to the internal GitLab
CI where it includes the following:
- check-changelog-addition: Checking the presence of
a change log log file for each raised MR.
- gitlint: Checking predetermined format of commit messages.
- uncrustify: Checking the c/c++ coding format.
- license: Checking that files contain copyright notices.
- Use the following pre-commit hooks:
- Trims trailing whitespace.
- Makes sure files end in a newline and only a newline.
- Prevent giant files from being committed.
- C/C++ code formatting with uncrustify.
- Check if banned unsafe C/C++ APIs are used in the code.
- Python code formatting with black and Flake8.
- Dependencies check which check that all submodule entries
in the manifest.yml are not missing a license attribute
- Third-Party IP check - show a warning in the MR whenever a
change to TPIP is detected. Changes include:
Removal of external project
Modification of external project URL, SHA or location in project
Modification of tpip source files
Signed-off-by: Ahmed Ismail <[email protected]>
fixup: ci: Add
pathlib is modern and there are a lot of improvements in pathlib. Signed-off-by: Ahmed Ismail <[email protected]>
Signed-off-by: Ahmed Ismail <[email protected]>
AhmedIsmail02
force-pushed
the
improve-internal-gitlab-ci
branch
from
3287623 to
a6e4211
Compare
urutva
approved these changes
Nov 13, 2023
aggarg
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is meant to add the following to the internal GitLab CI:
Improve the CI to support multiple applications and platforms.
Add the quality check stage to the CI where this stage should contain the following checks:
Changes include:
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.