Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link and Manfiest Verification CI-CD Checks, use FreeRTOS/CI-CD Formatting Action #18

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

Skptak
Copy link
Member

@Skptak Skptak commented Oct 31, 2023

Description

Use ubuntu 20.04 for formatting so that this repo can use the same formatting as all other FreeRTOS Repos

CMSIS Is not directly included in this repo, removing it from this repo's manifest.yml file

Fix a broken link in the aws-iot-example.md file, remove the trailing comma from a link, and add an exclude for a bash link

Add the link and manifest verification workflow to this repo. Bump checkout actions to v3 to remove the deprecation warnings

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Skptak Skptak requested a review from a team as a code owner October 31, 2023 18:24
@urutva
Copy link
Contributor

urutva commented Nov 2, 2023

@Skptak Thanks for the changes. Can you please add Signed-off-by: Full Name <email> to each commit. We've an internal CI check to verify that every commit contains Signed-off-by: Full Name <email>. Please check here for more information. Thanks.

formatting as all other FreeRTOS Repos.

Add the formatting bot to this repo.

CMSIS Is not directly included in this repo, removing it from this
repo's manifest.yml file

Fix a broken link in aws-iot-example.md, remove the trailing comma from
a link, and add an exclude for a bash link

Add the link and manifest verification workflow to this repo. Bump
checkout actions to v3 to remove the deprecation warnings.

Signed-off-by: Soren Ptak <[email protected]>
@Skptak
Copy link
Member Author

Skptak commented Nov 8, 2023

@urutva I fixed the commit message issue you mentioned, is that the change you needed/were looking for?
I squashed my commits while doing it, so now there's just the singular one as well.

@urutva urutva merged commit b7c5ffe into FreeRTOS:main Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants