Fix nightly build failure #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirnish
approved these changes
Jan 31, 2024
hugueskamba
approved these changes
Jan 31, 2024
urutva
force-pushed
the
fix-nightly-build-failure
branch
from
7b563b1 to
aee3c52
Compare
aggarg
approved these changes
Feb 5, 2024
Provide the device private key and certificate to the build script as parameters. In addition, provide timeout value to integration test script as parameter. Signed-off-by: Devaraj Ranganna <[email protected]>
* Change `ECHO_SERVER_ENDPOINT` from `localhost` to `127.0.0.1` as DNS resolution of `localhost` fails with FreeRTOS-TCP/IP. Therefore hardcode the numerical value. * Increase the transport interface test timeout to its maximum value by overriding the `TRANSPORT_TEST_WAIT_THREAD_TIMEOUT_MS` macro with value `0xFFFFFFFF`. This is required to ensure the nightly test in the internal CI passes. * Increase MQTT process loop timeout, so that the expected packet from the AWS IoT service is received successfully. Signed-off-by: Devaraj Ranganna <[email protected]>
The integration tests validates both secure and unsecure connections over TCP. However, unsecure TCP connection support was missing from FreeRTOS TCP/IP integration layer. Signed-off-by: Devaraj Ranganna <[email protected]>
Use FreeRTOS memory management APIs instead of using C library ones, as FRI is configured to use FreeRTOS memory management. Signed-off-by: Devaraj Ranganna <[email protected]>
With a lower timeout value (750), socket connection sporadically fails. Signed-off-by: Devaraj Ranganna <[email protected]>
The `TRANSPORT_TEST_BUFFER_WRITABLE_LENGTH` is set to `2048`. Reduce it to `1350`, so that the test data can be sent in a single ethernet packet. Without this change, it takes a very long time to complete transport tests and most of the times test fails. Signed-off-by: Devaraj Ranganna <[email protected]>
In order for one of the patches to be be cleanly applied, git config option `core.autocrlf` must be set to value `input`. The file `src/transport_interface/transport_interface_test.c` has `CRLF` line ending and patching it fails if `core.autocrlf` is not set to `input`. Signed-off-by: Devaraj Ranganna <[email protected]>
Fix firmware update cancellation and cleanup check by ensuring the result variable is initialized to the success value. The result variable was only set in case of failure if the cancellation and/or the cleanup failed. Signed-off-by: Ahmed Ismail <[email protected]>
urutva
force-pushed
the
fix-nightly-build-failure
branch
from
aee3c52 to
8806a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix nightly build failure
Test Steps
The changes validated in the CI as well as in nightly jobs. No regression found.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.