Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ml-apps: Fix building different ML apps subsequently #61

Merged

Conversation

hugueskamba
Copy link
Contributor

Description

When building ML apps, the MLEK downloads model resources for the model specified by a given application.
The FRI integration of the MLEK prevents these resources from being re-donwloaded if they already exist to speed up build time.

However, in the case of a different application being build, model resources have to be re-downloaded as different ML applications use different models.
To allow the re-download of model resources, the generated ML model resources subdirectory is now generated in the CMake build directory.

Building a different application requires triggering a clean build which will also delete the resources specific to a model used by another application.

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hugueskamba hugueskamba requested a review from a team as a code owner March 14, 2024 11:27
When building ML apps, the MLEK downloads model resources
for the model specified by a given application.
The FRI integration of the MLEK prevents these resources
from being re-donwloaded if they already exist to speed up
build time.

However, in the case of a different application being build,
model resources have to be re-downloaded as different ML
applications use different models.
To allow the re-download of model resources, the generated
ML model resources subdirectory is now generated in the CMake
build directory.

Building a different application requires triggering
a clean build which will also delete the resources specific
to a model used by another application.

Signed-off-by: Hugues Kamba Mpiana <[email protected]>
@hugueskamba hugueskamba force-pushed the dev/hugkam01/fix-building-different-ml-apps branch from 4635dcb to 061b36b Compare March 14, 2024 13:53
@moninom1
Copy link
Member

moninom1 commented Mar 14, 2024

Hello @hugueskamba, thank you for raising the PR! We will be looking further into it and update you accordingly, thank you for your patience!

@moninom1 moninom1 requested a review from aggarg March 15, 2024 03:32
@urutva urutva merged commit da155ca into FreeRTOS:main Mar 18, 2024
13 checks passed
@hugueskamba hugueskamba deleted the dev/hugkam01/fix-building-different-ml-apps branch March 18, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants