Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/davhaz01/upgrade tfm #69

Merged
merged 2 commits into from
May 17, 2024

Conversation

david-hazi-arm
Copy link
Contributor

@david-hazi-arm david-hazi-arm commented Apr 26, 2024

Description

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@jasonpcarroll jasonpcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments.

}

/*
* Form mbedtls 3.6.0 release note:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Form mbedtls 3.6.0 release note:
* From mbedtls 3.6.0 release note:

* psa_import_key() now only accepts RSA keys in the PSA standard formats.
* The undocumented ability to import other formats (PKCS#8, SubjectPublicKey,
* PEM) accepted by the pkparse module has been removed. Applications that
* need these formats can call mbedtls_pk_parse_{public,}key() followed by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is supposed to be mbedtls_pk_parse_{public,}key()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is from the release note:
https://github.com/Mbed-TLS/mbedtls/releases/tag/v3.6.0

The provisioning code which used by OTA has been changed,
because from mbedtls 3.6.0 the psa_import_key() only
accepts RSA keys in standard PSA format,
mbedtls_pk_import_into_psa() is used instead.

Signed-off-by: Dávid Házi <[email protected]>
@david-hazi-arm david-hazi-arm force-pushed the dev/davhaz01/upgrade_tfm branch from 8ac631e to db2099d Compare May 15, 2024 20:36
@david-hazi-arm david-hazi-arm marked this pull request as ready for review May 15, 2024 20:36
@david-hazi-arm david-hazi-arm requested a review from a team as a code owner May 15, 2024 20:36
@urutva urutva merged commit 16c43e6 into FreeRTOS:main May 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants