Use aws ecr docker image #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Jagodzinski <[email protected]> Signed-off-by: Ahmed Ismail <[email protected]>
Get the ubuntu base image from public aws ecr instead of docker registry. In addition: * Upgrade to ubuntu 22.04 from 20.04 because the eol for ubuntu 20.04 is 04/2025. * Python3.9 package is removed as it is not needed anymore. The python3.9 workaround required for VSI is handled as part of `tools/scripts/setup_python_vsi.sh` * Python 3.10 built from source is removed as it comes pre-installed with ubuntu 22.04 * Build and install uncrustify 0.69.0 as the version packaged with ubuntu 22.04 is higher than intended * Added vim configuration (~/.vimrc) to enable spell check in vim Signed-off-by: Devaraj Ranganna <[email protected]>
The VSI audio option for Corstone-315 should use `mps4_board.v_path` instead of `mps3_board.v_path`. Signed-off-by: Devaraj Ranganna <[email protected]>
`ccache` is a compiler cache used to reduce the compilation time where possible. The working of ccache is described in the manual https://ccache.dev/manual/4.10.2.html. Signed-off-by: Devaraj Ranganna <[email protected]>
The pipeline was failing due to a change in nvm, which was set to use the latest version. This commit fixes the version used at 'v22.7.0'. Signed-off-by: Reuben Cartwright <[email protected]>
kstribrnAmzn
approved these changes
Sep 6, 2024
amazonKamath
approved these changes
Sep 7, 2024
aggarg
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.