Implement single command for all steps of creating OTA update #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new command to `tools/scripts/createIoTThings.py` that 1. Creates a Thing and Policy. 2. Re-builds the target application (if required). 3. Creates a Bucket, Role, and Update. This command is documented in `aws_tool.md`. During application building, the script prints '.' on the same line and flushes. The command only takes 2 command line arguments, with the rest specified in a .json file, an example of which is also included in This commit as well as the `aws_tool.md` documentation. Only 3 fields in `aws_tool.md` need to be filled in. The command also re-uses AWS entities where possible. E.g. if the Role specified already exists, it checks it can access the Bucket name provided before re-using the role. Using Roles not created by your current account is not supported, as the script may be unable to assume them to check access to the Bucket. The motivation for this commit is to make creating OTA updates easier. This commit also introduces a new command for cleaning up all AWS entities specified by the .json config file. This command is called `cleanup-simplified`. It will force-delete everything (including bucket contents). This is not configurable. Signed-off-by: Reuben Cartwright <[email protected]>
This commit makes the script correctly ask before overwriting credentials. Previously, the script checked for 'dummy_thingname' and the default endpoint in 'aws_clientcredential.h' and only asked if these defaults were not present. These strings occur in more than one place in the header file so so this check is not sufficient to say the credentials #define'd have not been modified by the user. This commit makes the script check the entirety of the #define line. Signed-off-by: Reuben Cartwright <[email protected]>
urutva
approved these changes
Sep 13, 2024
aggarg
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new command to
tools/scripts/createIoTThings.pythatThis command is documented in
aws_tool.md.The command takes at most 2 command line arguments, with the rest
specified in a .json file, an example of which is also included in This
commit as well as the
aws_tool.mddocumentation.Only 3 fields in the settings
.jsonneed to be filled in.The command also re-uses AWS entities where possible. E.g. if
the role specified by the
.jsonalready exists, it checks it can access the Bucketname specified before re-using the role.
The motivation for this commit is to make creating OTA updates
easier.
This MR also introduces a new command for cleaning up all
AWS entities specified by the .json config file.
This command is called
cleanup-simplified.It will force-delete everything (including bucket contents). This
is not configurable.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.