Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for clean build with latest ESP-IDF v5.4 #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DakshitBabbar
Copy link
Member

Description

Context:
The CI checks for this Repository requires that the code is built without errors with the latest version of ESP-IDF (v5.4) along with other versions. It happens to be that a number of warnings that were suppressed in the previous ESP-IDF versions are now treated as errors and the build fails for it. Hence this PR updates the relevant code to build it without any warnings or errors with the latest ESP-IDF v5.4.

This PR:

  • Removes the definitions of unused functions.
  • Removes the instances of constness related warnings
  • Updates the esp-aws-iot submodule pointed to the updated code that builds with the latest ESP-IDF v5.4

Test Steps

The code is building successfully with the latest ESP-IDF v5.4

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant