Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Settings tooltips cut off at the bottom #6709

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ozrendev
Copy link
Contributor

@ozrendev ozrendev commented Feb 1, 2025

Fix: Settings tooltips cut off at the bottom

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #6704

Description

Adds a larger margin to the bottom of setting sections when in mobile view

Testing

Resize the window while in Settings view and hover over an affected tooltip

Screenshots

Before
2025-02-02_17-06-28

After
2025-02-02_17-05-09

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Feb 1, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) February 1, 2025 04:12
@absidue
Copy link
Member

absidue commented Feb 2, 2025

When making UI changes it is always a good idea to provide before and after screenshots. Please re-add the parts of the template that you removed and add screenshots to it.

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Feb 2, 2025
@ChunkyProgrammer ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Feb 3, 2025
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@MarmadileManteater
Copy link
Contributor

I don't like this solution because it doesn't actually fix the core problem. It punts it down the road.

Also, it creates an issue on small displays where there is now a bunch of negative space below each settings section.

@MarmadileManteater
Copy link
Contributor

I believe a better way to fix this would be to remove the overflow-*: hidden styles, but there are likely unexpected consequences to that. I feel like I've tried to address this issue before unsuccessfully.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Settings tooltips are cut off at the bottom
5 participants