Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add trunk branch to matrix #41

Merged
merged 3 commits into from
Mar 19, 2025
Merged

chore: Add trunk branch to matrix #41

merged 3 commits into from
Mar 19, 2025

Conversation

aragon999
Copy link
Member

Merge once the build is working again.

@shyim
Copy link
Member

shyim commented Mar 19, 2025

I think thats because you install phpstan 1 🤔 , in trunk should be already 2 🤔

@aragon999
Copy link
Member Author

aragon999 commented Mar 19, 2025

I just investigated the issue, the problem is, that due to the flags --prefer-lowest --prefer-stable when installing the composer dependencies, we install symfony/type-info in version 7.1.0.

But this was only compatible with phpstan 1 but not phpstan 2. The issue has been fixed in Symfony 7.1.8: symfony/symfony@ecb34a7

Maybe as a solution symfony/type-info <7.2 should be added to shopware/conflicts for 6.7: https://github.com/shopware/conflicts/blob/6.7.x/composer.json 🤔

@aragon999 aragon999 merged commit 4d3c520 into main Mar 19, 2025
98 checks passed
@aragon999 aragon999 deleted the chore/add-trunk branch March 19, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants