Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Klippain compatibility with HH v2.5 #517

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

Conversation

Benoitone
Copy link
Collaborator

@Benoitone Benoitone commented Feb 29, 2024

try to make klippain compatible with Happy_Hare v2.5
Actually in developpment in happy_hare variables branch

@Surion79
Copy link
Collaborator

could you put this please in a draft state? Or can it be already integrated?

@Benoitone
Copy link
Collaborator Author

need some tester before update HH...

@Surion79
Copy link
Collaborator

Surion79 commented Mar 2, 2024

A pull request is not required to use/test a branch

@Surion79
Copy link
Collaborator

Surion79 commented Mar 2, 2024

Instead of checking for mmu.enabled would it be possible via rename existing to set klippain mmu enabled to false/true if the related function in MMU is used?

@Surion79 Surion79 changed the base branch from main to develop March 2, 2024 18:18
@Surion79
Copy link
Collaborator

Surion79 commented Mar 2, 2024

i changed the base to develop, hopefully to prevent the issues of last time

@Benoitone
Copy link
Collaborator Author

For me it seems to be ok...
The new HH version has been released today...

@Benoitone Benoitone requested a review from Frix-x March 8, 2024 18:36
@Benoitone Benoitone added enhancement New feature or request help wanted Extra attention is needed next version This thing is already done or is planned in the next version in preparation labels Mar 9, 2024
@Surion79
Copy link
Collaborator

is it ready for review?

@Benoitone Benoitone removed the help wanted Extra attention is needed label Mar 14, 2024
@Benoitone
Copy link
Collaborator Author

with this version use with HHv2.5+ no need to have to add entries in printer.cfg
but if they exist they can override HH variables.

@Frix-x
Copy link
Owner

Frix-x commented Mar 20, 2024

I'll do a couple of minor changes to change some wording in the documentation and also add warning that <v2.5 is deprecated and will be removed in the future. This way we will be able to keep the code base more clean by removing in a next Klippain version all the checks about the HH version

@Frix-x
Copy link
Owner

Frix-x commented Mar 20, 2024

@Benoitone are the changes ok for you?
Especially the startup change as I changed a bit the "if" logic to add the deprecation warning and not sure it's ok like this.

@Benoitone
Copy link
Collaborator Author

Benoitone commented Mar 20, 2024

@Frix-x I rework a little bit yours startup modifications. I think it's ok now... can you check?

Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

@Fragmon
Copy link
Contributor

Fragmon commented May 1, 2024

Whats the status?

@Benoitone
Copy link
Collaborator Author

Whats the status?

Working on my side…

Copy link

github-actions bot commented Jun 1, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

@Frix-x
Copy link
Owner

Frix-x commented Jun 18, 2024

Hello @Benoitone , I'm coming back to the project and will work on merging this branch when you are ready :)
Is there anything that needs to be updated before a full review?

@Frix-x Frix-x added the tracking This issue is tracked and work will be done label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next version This thing is already done or is planned in the next version in preparation tracking This issue is tracked and work will be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants