Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added variable for timeout handling #525

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Surion79
Copy link
Collaborator

@Surion79 Surion79 commented Mar 3, 2024

added variable to prevent calling M84 on timeout.
With the G2Z beta, gantry sag is a potenial issue, especially if toolhead is located near the edges.
with the introduced variable, it is now possible to prevent M84 on timeout.

it was copied based on the already existing end print variables, except that i did not added the heater off due to functional safety concerns.

@Frix-x
Copy link
Owner

Frix-x commented Mar 4, 2024

Wouldn't this be a safety issue since a timeout means everything should usually stop to prevent a problem?
Keeping the motors under power seems a bit counterproductive and would add a security flaw IMHO...

@Surion79
Copy link
Collaborator Author

Surion79 commented Mar 4, 2024

my initial thought was that motors could stay on, but heater not over longer time. There are already some config options to change behaviour in timeout. Just adding the option to be able to change it without making it the default

Copy link

github-actions bot commented Apr 4, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

2 similar comments
Copy link

github-actions bot commented May 4, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

Copy link

github-actions bot commented Jun 3, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

Copy link
Owner

@Frix-x Frix-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a small change about the default value to be able to merge :)

@@ -73,6 +73,8 @@ variable_disable_motors_in_end_print: False
## Automatically turn-off heaters in the END_PRINT macro
variable_turn_off_heaters_in_end_print: True

## Automatically disable motors on timeout
variable_disable_motors_on_timeout: False
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the default to True here? The goal is to align it with the default(1) from the macro

@Frix-x Frix-x added the tracking This issue is tracked and work will be done label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking This issue is tracked and work will be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants