Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5160 based sensorless configs #532

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

EricZimmerman
Copy link
Collaborator

Add 2160 and 5160 sensorless

@EricZimmerman
Copy link
Collaborator Author

Added files based on work with Kraken to get it up and running. Klippy log attached as well for verification

KrakenKlippy.log

@Surion79
Copy link
Collaborator

Surion79 commented Mar 4, 2024

I would really reconsider the integration part. especially that the sense resistor option is very specific to Kraken, I don't think it is a good idea to put all in the same pot. Also removing the spi_speed on TMC2240 is not really topic in this PR?
in the config, we have for the early V0 release a "V0specific.cfg" on the Z axis i believe. So i think it would be an idea to consider to name it "KrakenSpecific" or something.
But well, something for @Frix-x to decide

@Surion79 Surion79 changed the base branch from main to develop March 4, 2024 22:37
@Surion79
Copy link
Collaborator

Surion79 commented Mar 4, 2024

and please, base branch to develop :)

@EricZimmerman
Copy link
Collaborator Author

Spi speed was doubled up in the file I removed it from.

Copy link

github-actions bot commented Apr 4, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

@EricZimmerman
Copy link
Collaborator Author

Ping and tease against develop

@Surion79
Copy link
Collaborator

well, i am not 100% happy with setting default rsense for Kraken on the tmc2160. but on the other hand, no one else has tmc2160 (yet)

@EricZimmerman
Copy link
Collaborator Author

i am just going by the kraken docs. its all i could find

Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

1 similar comment
Copy link

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

Copy link
Owner

@Frix-x Frix-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I htink there is a small mistake in this PR, can you have a check please?

Comment on lines +12 to +14
[tmc2240 stepper_x]
diag0_pin: ^!X_STOP
driver_SGT: -64
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here it's "tmc5160"

Comment on lines +20 to +22
[tmc2240 stepper_y]
diag0_pin: ^!Y_STOP
driver_SGT: -64 # -64 is most sensitive value, 63 is least sensitive
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: I think it's "tmc5160"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants