Skip to content

Clarify offline setup commands in README#17

Open
FrizzleM wants to merge 1 commit intomainfrom
codex/update-readme-for-offline-usage-commands-eu0mbu
Open

Clarify offline setup commands in README#17
FrizzleM wants to merge 1 commit intomainfrom
codex/update-readme-for-offline-usage-commands-eu0mbu

Conversation

@FrizzleM
Copy link
Owner

Motivation

  • Make the "For offline usage" instructions accurate by showing the actual commands required to run the Vite web installer from the repository root and the correct subdirectory to use.

Description

  • Update README.md to point the offline workflow at the quest-web-installer/ folder, add an explicit cd quest-web-installer step, separate development (npm run dev) and production (npm run build / npm run preview) command blocks, and close the previously unterminated fenced code block.

Testing

  • Inspected quest-web-installer/package.json with cat quest-web-installer/package.json to confirm the dev, build, and preview scripts exist and are correct.
  • Verified the rendered README section with nl -ba README.md | sed -n '54,72p' and nl -ba README.md | tail -n 30 to confirm the updated commands and formatting.

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8927fbd4d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

To create a production build locally:

```bash
cd quest-web-installer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the extra cd quest-web-installer

If someone follows the offline setup instructions top-to-bottom in a single shell, the previous block already leaves them inside quest-web-installer/, so this cd fails with No such file or directory before the production commands run. That makes the new production-build path unusable unless the reader manually backs out to the repo root or starts a fresh shell.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant