Bugfix: Using Resume to accelerate from a stopped position with Brake Hold Active causes malfunction error codes and various warning lights to appear #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if position matters in this file but added brake hold related can messaging.
Added conditional logic to not apply fix for pedal users Co-Authored-By: Micim987 <[email protected]>
|
Thank you for your PR! If you're not already in the FrogPilot Discord, feel free to join and let me know you've opened a PR! |
FrogAi
force-pushed
the
MAKE-PRS-HERE
branch
17 times, most recently
from
1ce109b to
2ab9651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Honda Clarity specific bug owing to the fact that it uses a proxy board to handle the second CANBUS.
Problem statement:
“If brake hold is on but unengaged and OP is on in reg mode then no problem. If brake hold is engaged and you turn on OP and the car in front moves my car will fault.”
Bug Recreation:
Ok, today i recreate that bug on purpose. Like this:
Enable brake hold and ACC
Stop with brake pedal and wait till HOLD engaded
Press res + to depart
(Here is the point of no return)
Car tries to move while being hold simultaneously and now you have 2 option and 1 second to make choice:
a. Either nudge car with gas pedal, hold disengaged and all ok
b. Do nothing, just wait. Car will do some convulsive trying to depart and eventualy stops, traction motor completely off and bunch of christmas lights errors on dashboard..
For me it took 2 or 3 reboot of car to make it move, with errors but it mooved..
Fix / Workaround Description:
DBC entries for Brake Hold added
brakeHoldActive now reads BRAKE_HOLD instead of VSA_STATUS as that's what the Clarity is expecting.
Cars with GasInterceptor are not affected by the bug so have been logically carved out.
PR's in upstream:
commaai/opendbc#2671
commaai#36121