-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button/link consistency #223
Button/link consistency #223
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of changing buttons to text can we change just the square ones to round? as they seems more good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the contribution @khushijohri2001 Looks good |
Fixes Issue
Resolved #222
Changes proposed
There is no consistency in the styling and naming of buttons. Somewhere the buttons/links are rounded and somewhere it is squared. In the header, the Mentorship button has the link to Discord but it should be Join Community.
Rename Join Community to Join Discord Community, to specify and give a hit of what the community is like.
(Changes in Header, Footer, and other sections)
Check List (Check all the applicable boxes)
Screenshots
Button.style.and.rename.mov
Note to reviewers