Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tabs for HTML Video in English and in Hindi #234

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Added tabs for HTML Video in English and in Hindi #234

merged 1 commit into from
Oct 22, 2023

Conversation

anamika133m
Copy link
Contributor

Fixes Issue

Fixes #203

Changes proposed

  • Added two tabs for showing HTML video after the 'watch now' section in batch/learn/html.
  • One tab is for HTML in Hindi video and one is for English.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot (687)

@vercel
Copy link

vercel bot commented Oct 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontendfreaks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2023 7:41pm

github-actions[bot]
github-actions bot reviewed Oct 21, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request and welcome to our community! We will be getting back to you soon . Your patience will be greatly appreciated! Thanks! 🥳

khushijohri2001
khushijohri2001 approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@khushijohri2001 khushijohri2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me!

@Vishal-raj-1 Vishal-raj-1 merged commit 3f64b71 into FrontendFreaks:master Oct 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Vishal-raj-1 Vishal-raj-1 Vishal-raj-1 approved these changes

@khushijohri2001 khushijohri2001 khushijohri2001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Want to add "HTML in Hindi" video of web dev Bootcamp in batch/learn/html/basic section
3 participants
@anamika133m @Vishal-raj-1 @khushijohri2001