Skip to content

Latest commit

 

History

History
39 lines (28 loc) · 1.45 KB

maintainers.md

File metadata and controls

39 lines (28 loc) · 1.45 KB

Maintainers

Each repository in the system has a set of maintainers. These are tracked in files all aptly named MAINTAINERS. One of these will always be present in the root of a repository. Many directories will have their own MAINTAINERS files.

Contents

Each file lists a number of individuals (via their email address) who are familiar with and can provide code review for the contents of that directory. We strive to always have at least two individuals in a given file. Anything with just one is either too fine grained to deserve its own, or is in need of someone else to learn enough about the code to feel comfortable approving changes to it or answering questions about it.

Responsibilities

MAINTAINERS are not OWNERS, and in particular code review +2 is not gated on membership in the appropriate file.

Rather, these files are about being able to find an individual who knows about and is responsible for code in the system. I.e. someone who can answer questions about the role of the code in the system, or who can review changes to the code in question (or at least provide more appropriate reviewers).

Tools

INTK-108 tracks the work to stand up more infra tooling around these, such as suggesting reviewers automatically in Gerrit.

Format

We use the Gerrit find-owners plugin file format for our MAINTAINERS files.