Skip to content

Comments

feat: expose id method to wasm#988

Merged
mchristopher merged 5 commits intomasterfrom
expose-tx-id-to-typescript
Feb 19, 2026
Merged

feat: expose id method to wasm#988
mchristopher merged 5 commits intomasterfrom
expose-tx-id-to-typescript

Conversation

@mchristopher
Copy link
Member

Exposing an .id() function to the Transaction WASM target. This creates a way for the WASM to verify a transaction ID without needing the full language SDK.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@cursor
Copy link

cursor bot commented Feb 19, 2026

PR Summary

Medium Risk
Touches public WASM/TypeScript API surface and changes how WASM NPM packages are bundled and published (new exports/entrypoints and OIDC-based publishing), which could break consumers or release automation if misconfigured.

Overview
Exposes transaction identification to the TypeScript WASM target by adding id(chainId) and cachedId() exports for Transaction and all typed transaction variants (Script, Create, Mint, Upgrade, Upload).

Updates the WASM NPM packaging templates to generate typed index.d.ts files, make initWasm() idempotent, and add a new /slim entrypoint that requires callers to provide the WASM module (plus a ./wasm export). The build tooling is adjusted accordingly (Rollup v4 upgrade, new rollup config outputs, .pnpm-store ignore), and CI release publishing switches to Node 22 with npm 11 plus OIDC provenance (NPM_CONFIG_PROVENANCE) and required id-token permissions.

Written by Cursor Bugbot for commit dd270ce. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Copy link
Member

@Dentosal Dentosal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure why these NPM changes are necessary, but it all looks correct.

@mchristopher mchristopher added this pull request to the merge queue Feb 19, 2026
Merged via the queue into master with commit c9f3d32 Feb 19, 2026
45 of 46 checks passed
@mchristopher mchristopher deleted the expose-tx-id-to-typescript branch February 19, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants