Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve node incompatibility warnings #2283

Closed
arboleya opened this issue May 10, 2024 · 3 comments · Fixed by #2925
Closed

Improve node incompatibility warnings #2283

arboleya opened this issue May 10, 2024 · 3 comments · Fixed by #2925
Assignees
Labels
chore Issue is a chore

Comments

@arboleya
Copy link
Member


We do have checks in place, but we call fetchChain before the check occur.

A possible solution would be to make an additional request only for the node's version before the rest.

It requires some consideration. Also, we'd need to cache this result to avoid unnecessary requests.

@arboleya arboleya added the chore Issue is a chore label May 10, 2024
@nedsalk nedsalk self-assigned this May 10, 2024
@arboleya arboleya added this to the Mainnet milestone Jun 9, 2024
@arboleya arboleya removed the mainnet label Jun 9, 2024
@nedsalk
Copy link
Contributor

nedsalk commented Jun 19, 2024

I'm not sure if it makes sense anymore to do this now that fuel-core releases are backwards compatible and errors such as the one reported in the forum post shouldn't be happening anymore. This would mean an additional request towards the network whenever a Provider.create call is done for the first time and I don't think it's worth it. @FuelLabs/sdk-ts

If anything, it doesn't look like a p0 issue anymore but a p2.

@arboleya arboleya added p2 and removed p0 labels Jun 19, 2024
@arboleya
Copy link
Member Author

Makes sense — priority decreased.

@nedsalk nedsalk removed their assignment Jun 20, 2024
@arboleya
Copy link
Member Author

arboleya commented Jul 7, 2024

We should keep it because things like the [graphql] API can change and break stuff.

Better have a warning to be safe.

@arboleya arboleya added p1 and removed p2 labels Jul 7, 2024
@arboleya arboleya modified the milestones: 0.x mainnet, 0.x post-launch Jul 19, 2024
@arboleya arboleya added p2 and removed p1 labels Jul 19, 2024
@arboleya arboleya removed this from the 0.x post-launch milestone Jul 19, 2024
@arboleya arboleya removed the p2 label Aug 2, 2024
@Torres-ssf Torres-ssf self-assigned this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants