Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve node incompatibility warning #2925

Merged
merged 15 commits into from
Aug 19, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Aug 13, 2024

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely is an improvement. Given that this part of the API shouldn't be changing anymore, I created FuelLabs/fuel-core#2083 for network benefits. It'd make the changes in this PR obsolete, but I think it's worthwhile.

@petertonysmith94
Copy link
Contributor

It definitely is an improvement. Given that this part of the API shouldn't be changing anymore, I created FuelLabs/fuel-core#2083 for network benefits. It'd make the changes in this PR obsolete, but I think it's worthwhile.

@nedsalk Would this not lead to the same error messages that are in the forum post?

@nedsalk
Copy link
Contributor

nedsalk commented Aug 15, 2024

@petertonysmith94 No, because that error happened due to fuel-core version mismatches between beta-5 and testnet versions which had breaking changes between them. There shouldn't be such drastic breaking changes to the graphql API anymore so we can do it.

@Torres-ssf
Copy link
Contributor Author

@nedsalk I am not confident that breaking changes within the graphQL API will no longer happen.

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.21%(+0%) 71.41%(+0.03%) 77.35%(+0%) 79.34%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.48%
(+0%)
79.71%
(+1.45%)
84%
(+0%)
88.73%
(+0%)

@Torres-ssf Torres-ssf merged commit 2be4a5e into master Aug 19, 2024
20 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/warn-node-incompatibility-before-error branch August 19, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve node incompatibility warnings
6 participants