fix: esm support for keystore package and crypto ops
#1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arboleya
commented
Jun 6, 2023
arboleya
commented
- Close Keystore package does not work in a Node ESM environment #909
Coverage report
Show new covered files 🐣
Test suite run success1074 tests passing in 184 suites. Report generated by 🧪jest coverage report action from 912e57a |
7 tasks
This comment was marked as outdated.
This comment was marked as outdated.
arboleya
requested review from
digorithm,
camsjams,
Torres-ssf,
Dhaiwat10,
danielbate and
nedsalk
as code owners
Torres-ssf
approved these changes
Jul 23, 2023
danielbate
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.