Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add helper method to Abi Interface #1123

Merged
merged 9 commits into from
Jul 25, 2023
Merged

feat: add helper method to Abi Interface #1123

merged 9 commits into from
Jul 25, 2023

Conversation

LuizAsFight
Copy link
Contributor

@LuizAsFight LuizAsFight commented Jul 25, 2023 •
edited
Loading

Problem:

As now the old ABI format is removed, we don't have easy access to type of ABI fragments anymore

Solution:

implements a new helper method getTypeById, the objective is to provide an easy way to get abi types:

Usage:

const abiInterface = new Interface(abi);

const abiType = abiInterface.getTypeById(10);

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023 •
edited
Loading

This PR is published in NPM with version 0.0.0-pr-1123-20230725163710

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
83.56% (+0.01% 🔼)
 4264/5103
🟡 Branches 62.71% 624/995
🟡 Functions
72.92% (+0.08% 🔼)
 727/997
🟢 Lines
83.69% (+0.01% 🔼)
 4080/4875

Test suite run success

1051 tests passing in 181 suites.

Report generated by 🧪jest coverage report action from 2e9b80a

@LuizAsFight
Merge branch 'lf/fix/cross-fetch-version' of github.com:FuelLabs/fuel…
ed4257b 
…s-ts into lf/feat/interface-get-type-id

 Please enter a commit message to explain why this merge is necessary,
@LuizAsFight
chore: changeset
c285753
@arboleya
Copy link
Member

@nedsalk More breaking changes?

@LuizAsFight LuizAsFight marked this pull request as ready for review July 25, 2023 16:48
@LuizAsFight LuizAsFight merged commit b4d78c1 into master Jul 25, 2023
@LuizAsFight LuizAsFight deleted the lf/feat/interface-get-type-id branch July 25, 2023 17:59
@github-actions github-actions bot mentioned this pull request Jul 25, 2023
Merged
nedsalk pushed a commit that referenced this pull request Jul 25, 2023
@LuizAsFight @nedsalk
feat: add helper method to Abi Interface (#1123)
e31291f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@camsjams camsjams Awaiting requested review from camsjams

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@LuizAsFight LuizAsFight

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuizAsFight @arboleya @Torres-ssf