Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update eslint, prettier, typescript, typedoc #1368

Merged
merged 6 commits into from
Oct 30, 2023
Merged

chore: update eslint, prettier, typescript, typedoc #1368

merged 6 commits into from
Oct 30, 2023

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Oct 24, 2023 •
edited
Loading

This PR is mergable as-is and is for the purpose of splitting relevant and irrelevant changes made in #1356, as requested here.

It also updates jest and ts-jest just because that's necessary for #1356 to work, but it shouldn't interfere with #1310 as the updates are for minor versions.

@nedsalk nedsalk self-assigned this Oct 24, 2023
@nedsalk nedsalk mentioned this pull request Oct 24, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 85.04% 5334/6272
🟡 Branches 67.27% 781/1161
🟡 Functions 74.53% 875/1174
🟢 Lines 85.1% 5099/5992

Test suite run success

1300 tests passing in 230 suites.

Report generated by 🧪jest coverage report action from ebab95a

@nedsalk nedsalk marked this pull request as ready for review October 24, 2023 07:37
@nedsalk nedsalk enabled auto-merge (squash) October 24, 2023 07:37
camsjams
camsjams previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@camsjams camsjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nedsalk nedsalk changed the title chore: update eslint, prettier, typescript chore: update eslint, prettier, typescript, typedoc Oct 26, 2023
@nedsalk nedsalk disabled auto-merge October 26, 2023 12:40
@nedsalk nedsalk enabled auto-merge (squash) October 26, 2023 12:40
Dhaiwat10
Dhaiwat10 previously approved these changes Oct 27, 2023
View reviewed changes
.eslintrc.js Show resolved Hide resolved
arboleya
arboleya reviewed Oct 27, 2023
View reviewed changes
jest.env.ts Outdated Show resolved Hide resolved
@nedsalk nedsalk dismissed stale reviews from Dhaiwat10 and camsjams via 77a9850 October 30, 2023 11:59
@nedsalk nedsalk merged commit 5b4aee1 into master Oct 30, 2023
9 checks passed
@nedsalk nedsalk deleted the ns/chore/update-formatting-packages branch October 30, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@camsjams camsjams Awaiting requested review from camsjams

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

Assignees

@nedsalk nedsalk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nedsalk @arboleya @camsjams @Torres-ssf @Dhaiwat10