Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: merge error related pages #2198

Merged
merged 25 commits into from
Jun 28, 2024
Merged

docs: merge error related pages #2198

merged 25 commits into from
Jun 28, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Apr 29, 2024 •
edited
Loading

@petertonysmith94 petertonysmith94 added the docs Requests pertinent to documentation label Apr 29, 2024
@petertonysmith94 petertonysmith94 self-assigned this Apr 29, 2024
@petertonysmith94 petertonysmith94 changed the title docs: combined error related pages docs: merge error related pages Apr 29, 2024
@petertonysmith94 petertonysmith94 added the blocked Something is blocking development on this issue label May 1, 2024
@petertonysmith94 petertonysmith94 mentioned this pull request May 1, 2024
Closed
@petertonysmith94
Copy link
Contributor Author

Closing this PR, can re-open once the following has been addressed.

@arboleya arboleya deleted the ps/docs/merge-errors-pages branch May 1, 2024 12:22
@arboleya arboleya restored the ps/docs/merge-errors-pages branch May 1, 2024 13:04
@arboleya arboleya deleted the ps/docs/merge-errors-pages branch May 1, 2024 13:39
@petertonysmith94 petertonysmith94 removed the blocked Something is blocking development on this issue label Jun 26, 2024
@petertonysmith94 petertonysmith94 restored the ps/docs/merge-errors-pages branch June 26, 2024 14:47
@petertonysmith94 petertonysmith94 added this to the 0.x mainnet milestone Jun 26, 2024
@petertonysmith94 petertonysmith94 marked this pull request as ready for review June 26, 2024 16:29
danielbate
danielbate reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, mostly just some nits

apps/docs/.vitepress/config.ts Show resolved Hide resolved
apps/docs/src/guide/errors/index.md Outdated Show resolved Hide resolved
apps/docs/src/guide/errors/index.md Outdated Show resolved Hide resolved
apps/docs/src/guide/errors/index.md Outdated Show resolved Hide resolved
apps/docs/src/guide/errors/index.md Outdated Show resolved Hide resolved
apps/docs/src/guide/errors/index.md Outdated Show resolved Hide resolved
apps/docs/src/guide/errors/index.md Outdated Show resolved Hide resolved
apps/docs/src/guide/errors/index.md Outdated Show resolved Hide resolved
apps/docs/src/guide/errors/index.md Outdated Show resolved Hide resolved
@petertonysmith94 petertonysmith94 enabled auto-merge (squash) June 28, 2024 14:46
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
80.29%(-0.01%) 71.8%(+0%) 77.56%(+0%) 80.37%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit dddde62 into master Jun 28, 2024
19 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/docs/merge-errors-pages branch June 28, 2024 14:49
@fuel-service-user fuel-service-user mentioned this pull request Jun 28, 2024
Open
@arboleya arboleya mentioned this pull request Jun 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@nedsalk nedsalk nedsalk approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
docs Requests pertinent to documentation
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging this pull request may close these issues.

Combine Errors and ErrorCodes documentation pages
4 participants
@petertonysmith94 @arboleya @danielbate @nedsalk