Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: implement pagination for Account methods #2408

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

feat!: implement pagination for Account methods #2408

wants to merge 53 commits into from
+830 −353

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented May 28, 2024 •
edited
Loading

Breaking Changes:

The return of the following methods was modified to support pagination:

@Torres-ssf Torres-ssf added the chore Issue is a chore label May 28, 2024
@Torres-ssf Torres-ssf self-assigned this May 28, 2024
@arboleya arboleya added this to the 0.x post-launch milestone Jun 12, 2024
arboleya
arboleya reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small detail about the PR description, can we also have before/after code snippets for the breaking changes? It can be helpful to let people know what needs to be updated without having to dig into the code.

.fuel-core/configs/stateConfig.json Outdated Show resolved Hide resolved
petertonysmith94
petertonysmith94 reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comment 🥇

packages/account/src/providers/provider.ts Show resolved Hide resolved
packages/account/src/providers/provider.ts Outdated Show resolved Hide resolved
apps/docs/src/guide/provider/pagination.md Outdated Show resolved Hide resolved
apps/docs/src/guide/provider/pagination.md Show resolved Hide resolved
apps/docs-snippets/src/guide/provider/querying-the-chain.test.ts Outdated Show resolved Hide resolved
@Torres-ssf Torres-ssf marked this pull request as draft June 24, 2024 13:58
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.5%(-0.04%) 71.58%(+0.21%) 76.89%(-0.02%) 79.57%(-0.05%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 81.15%
(-3.09%)		 63.93%
(-3.23%)		 81.81%
(+0%)		 80.85%
(-3.07%)
🔴 packages/account/src/providers/provider.ts 68.76%
(+1.19%)		 63.82%
(+5.54%)		 73.8%
(-0.61%)		 68.71%
(+0.9%)

@Torres-ssf Torres-ssf marked this pull request as ready for review July 1, 2024 00:57
@Torres-ssf Torres-ssf added p1 Medium priority and removed chore Issue is a chore labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx left review comments

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@Torres-ssf Torres-ssf

Labels
feat Issue is a feature p1 Medium priority
Projects
None yet
Milestone
0.x post-launch
Development

Successfully merging this pull request may close these issues.

Implement pagination on Wallet for getCoins / getBalances
7 participants
@Torres-ssf @fuel-service-user @arboleya @maschad @petertonysmith94 @nedsalk @xgreenx