feat: pre-fill address and amount in create-fuels faucet
#2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhaiwat10
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
Dhaiwat10
changed the title
create-fuels templatecreate-fuels faucet
maschad
previously approved these changes
Jun 4, 2024
arboleya
requested changes
Jun 5, 2024
There was a problem hiding this comment.
After the great addition below, we must consider increasing the template coverage:
A quick new step/assertion here should do it.
Dhaiwat10
commented
Jun 12, 2024
nedsalk
approved these changes
Jun 13, 2024
maschad
approved these changes
Jun 13, 2024
|
Coverage Report:
Changed Files:
|
arboleya
approved these changes
Jun 13, 2024
maschad
pushed a commit
that referenced
this pull request
Jun 17, 2024
* feat: pre-fill address and amount in `create-fuels` template * update changeset * add an integration test for the faucet page * disable .only * fix lint error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After this PR, whenever someone opens the faucet page, the inputs will be pre-filled with default values so they can just click the button and get funds.
Closes #2389