Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: stop piping into process.stdout/stderr and use console.log #2558

Merged
merged 29 commits into from
Jul 3, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Jun 19, 2024

This PR substitutes process.stdout and process.stderr usage with console.log in our whole codebase because the logs would sometimes get removed once the process finishes.

Breaking changes

Removed debugEnabled property from launchNode inputs, which was used to read from stdout which isn't used by fuel-core internally.

@nedsalk nedsalk added the bug Issue is a bug label Jun 19, 2024
@nedsalk nedsalk self-assigned this Jun 19, 2024
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to update all process.stdout to console.log?

@petertonysmith94 petertonysmith94 added this to the 0.x mainnet milestone Jun 21, 2024
@nedsalk
Copy link
Contributor Author

nedsalk commented Jun 21, 2024

@petertonysmith94 I can do that in this PR, I'll put it into draft mode until it's ready again.

@nedsalk nedsalk marked this pull request as draft June 21, 2024 13:42
@arboleya
Copy link
Member

@nedsalk Are you also resolving #2248 in this PR?

If yes, please remember to close it in the PR description.

@nedsalk nedsalk changed the title fix: error disappearing on fuels init command fix: stop piping into process.stdout/stderr and use console.log Jun 27, 2024
@nedsalk nedsalk force-pushed the ns/fix/stop-silencing-errors-fuels-init branch from 65e4d5e to aa25af1 Compare June 27, 2024 10:22
@nedsalk nedsalk marked this pull request as ready for review June 27, 2024 10:38
@nedsalk nedsalk enabled auto-merge (squash) July 1, 2024 10:21
@nedsalk nedsalk force-pushed the ns/fix/stop-silencing-errors-fuels-init branch from e31fb99 to f4f98ef Compare July 1, 2024 10:22
Torres-ssf
Torres-ssf previously approved these changes Jul 1, 2024
@nedsalk nedsalk changed the title fix: stop piping into process.stdout/stderr and use console.log fix!: stop piping into process.stdout/stderr and use console.log Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Coverage Report:

Lines Branches Functions Statements
79.55%(+0.01%) 71.35%(-0.02%) 76.95%(+0.04%) 79.63%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/test-utils/launchNode.ts 100%
(+0%)
85.96%
(-0.48%)
78.57%
(+0.8%)
94.91%
(-0.04%)
🔴 packages/errors/src/test-utils/expect-to-throw-fuel-error.ts 96%
(+0.17%)
94.44%
(+0%)
100%
(+0%)
96%
(+0.17%)

@nedsalk nedsalk merged commit 7befc6a into master Jul 3, 2024
28 of 29 checks passed
@nedsalk nedsalk deleted the ns/fix/stop-silencing-errors-fuels-init branch July 3, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop silencing errors during fuels init command Stop silencing errors during launchNode startup
5 participants