Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [email protected] upgrade #2566

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Jun 20, 2024

This PR:

  • Upgrades forc to 0.61.0
  • Feature tests for str, coder was introduced already in v1 based on the spec
  • Fix for str in typegen to import the required type
  • Enabled raw_slice in script test

@danielbate danielbate added the chore Issue is a chore label Jun 20, 2024
@danielbate danielbate added this to the 0.x mainnet milestone Jun 20, 2024
@danielbate danielbate self-assigned this Jun 20, 2024
@danielbate danielbate added the blocked Something is blocking development on this issue label Jun 20, 2024
@danielbate
Copy link
Contributor Author

I believe all necessary upgrade work has been done, but this work is now blocked due to a Memory Overflow with a lot of our Vec tests. This has been reported to the Sway team.

@arboleya
Copy link
Member

[..] This has been reported to the Sway team.

Could you please link the Sway issue here for easy tracking?

@@ -12,7 +12,7 @@ struct Wrapper<T> {
}

fn validate_raw_slice(input: raw_slice) {
let vec: Vec<u64> = Vec::from(input);
let vec: Vec<u8> = Vec::from(input);
Copy link
Contributor Author

@danielbate danielbate Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raw_slice contains u8 bytes not u64, so this test needed updating. This was updated initially in #1673 but only now can we compile theraw_slice in script test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the issue you mentioned, or something else?

Just for clarity, I was referring to a GH issue, but I only found this one for you:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the confusion, this was an internal report. This is now tracked here:

@danielbate
Copy link
Contributor Author

For tracking, this PR is currently blocked by:

@danielbate
Copy link
Contributor Author

CI is also currently failing as it is running out of memory, this has also been reported:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something is blocking development on this issue chore Issue is a chore
Projects
None yet
2 participants