Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increate test timeout for e2e script #2632

Merged
merged 9 commits into from
Jun 28, 2024

Conversation

Torres-ssf
Copy link
Contributor

I've seen this report 2 times already

@Torres-ssf Torres-ssf enabled auto-merge (squash) June 26, 2024 15:19
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's still happening

@danielbate danielbate requested a review from maschad June 27, 2024 11:01
@maschad
Copy link
Member

maschad commented Jun 27, 2024

@Torres-ssf the error being thrown seems related to devnet faucet, what leads you to believe a timeout increase would solve this?

@Torres-ssf
Copy link
Contributor Author

@Torres-ssf the error being thrown seems related to devnet faucet, what leads you to believe a timeout increase would solve this?

@maschad There seems to be an issue with the devnet, the problem is not specific to the faucet.

I misinterpreted the issue initially, thinking it was caused by a timeout. However, the timeout occurred due to the devnet issue.

I will mark this PR as awaiting before closing it because I recall seeing this test fail a couple of times before due to timeout, but when the devnet was working properly, of course.

@Torres-ssf Torres-ssf added the awaiting We need further input from the author label Jun 27, 2024
@maschad
Copy link
Member

maschad commented Jun 27, 2024

Sounds good @Torres-ssf , you may want to convert it to draft as well, or the stale automation may be disrupted if someone interacts with the PR mistakenly thinking it's ready for review. We can re-open for review when devnet is stabilized.

@Torres-ssf Torres-ssf removed the awaiting We need further input from the author label Jun 28, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
80.29%(+0%) 71.8%(+0%) 77.56%(+0%) 80.37%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 dismissed maschad’s stale review June 28, 2024 15:03

Failing due to buggy devnet

@Torres-ssf Torres-ssf merged commit b17ff62 into master Jun 28, 2024
19 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/increase-e2e-ci-test-timeout branch June 28, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants