Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: launchNode.cleanup not killing node in last test of test group #2718

Merged
merged 39 commits into from
Jul 11, 2024
Merged

fix!: launchNode.cleanup not killing node in last test of test group #2718

merged 39 commits into from
Jul 11, 2024

Commits on Jul 7, 2024

  1. test: add test

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    23e8898 View commit details
    Browse the repository at this point in the history

  2. fix: the problem

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    41de3f2 View commit details
    Browse the repository at this point in the history

  3. add comment

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    3db78c0 View commit details
    Browse the repository at this point in the history

  4. remove tree-kill dependency and refactor accordingly

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    b64dcd4 View commit details
    Browse the repository at this point in the history

  5. chore: changeset

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    4061564 View commit details
    Browse the repository at this point in the history

  6. chore: changeset v2

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    f19b83f View commit details
    Browse the repository at this point in the history

  7. remove unused type

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    b87cb98 View commit details
    Browse the repository at this point in the history

  8. return early

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    db7404a View commit details
    Browse the repository at this point in the history

  9. clean up all side effects and then kill

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    48cb1eb View commit details
    Browse the repository at this point in the history

  10. "a test", not "an test"

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    16ddc83 View commit details
    Browse the repository at this point in the history

  11. oops, remove test.only

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    07d2f6c View commit details
    Browse the repository at this point in the history

  12. add test group

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    b454fa3 View commit details
    Browse the repository at this point in the history

  13. add .only to be explicit about it

    @nedsalk
    nedsalk committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    aeb7ff8 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. remove tree-kill from fuels

    @nedsalk
    nedsalk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    44271a1 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into ns/fix/launch-node-… 

    …cleanup
    @nedsalk
    nedsalk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    dc8a91a View commit details
    Browse the repository at this point in the history

  3. re-add accidental bun removal

    @nedsalk
    nedsalk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3640d19 View commit details
    Browse the repository at this point in the history

  4. use object

    @nedsalk
    nedsalk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4e33a34 View commit details
    Browse the repository at this point in the history

  5. works now?

    @nedsalk
    nedsalk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    eb09115 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into ns/fix/launch-node-cleanup

    @nedsalk
    nedsalk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1563169 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into ns/fix/launch-node-cleanup

    @nedsalk
    nedsalk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    a2526c5 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into ns/fix/launch-node-cleanup

    @nedsalk
    nedsalk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6211101 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into ns/fix/launch-node-cleanup

    @nedsalk
    nedsalk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    8a1b070 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into ns/fix/launch-node-cleanup

    @nedsalk
    nedsalk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5fab757 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Merge remote-tracking branch 'origin/master' into ns/fix/launch-node-… 

    …cleanup
    @nedsalk
    nedsalk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    fcb88b0 View commit details
    Browse the repository at this point in the history

  2. remove side effects on 'error' and 'exit' effects

    @nedsalk
    nedsalk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1babf70 View commit details
    Browse the repository at this point in the history

  3. cover child.pid as undefined

    @nedsalk
    nedsalk committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a73ff57 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Merge branch 'master' into ns/fix/launch-node-cleanup

    @Torres-ssf
    Torres-ssf committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4cf98c8 View commit details
    Browse the repository at this point in the history

  2. fix: kill process group

    @nedsalk
    nedsalk committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    823c33a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into ns/fix/launch-node-… 

    …cleanup
    @nedsalk
    nedsalk committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    bf612e3 View commit details
    Browse the repository at this point in the history

  4. verify external killing removes side-effects

    @nedsalk
    nedsalk committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ebcf55c View commit details
    Browse the repository at this point in the history

  5. remove unnecessary truthy check

    @nedsalk
    nedsalk committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b7cfab6 View commit details
    Browse the repository at this point in the history

  6. remove enormous timeout

    @nedsalk
    nedsalk committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    3e1b704 View commit details
    Browse the repository at this point in the history

  7. avoid dirty exit when node already killed

    @nedsalk
    nedsalk committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e7abaee View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into ns/fix/launch-node-cleanup

    @nedsalk
    nedsalk committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    3c0c6d5 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/master' into ns/fix/launch-node-… 

    …cleanup
    @nedsalk
    nedsalk committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    71d4add View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into ns/fix/launch-node-cleanup

    @nedsalk
    nedsalk committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c4491e6 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into ns/fix/launch-node-cleanup

    @maschad
    maschad committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    817c6ea View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Merge branch 'master' into ns/fix/launch-node-cleanup

    @nedsalk
    nedsalk committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c3d00a2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ns/fix/launch-node-cleanup

    @nedsalk
    nedsalk committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e006dbe View commit details
    Browse the repository at this point in the history