Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve issue templates #2738

Merged
merged 35 commits into from
Jul 23, 2024
Merged

chore: improve issue templates #2738

merged 35 commits into from
Jul 23, 2024

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Jul 8, 2024

Summary

Improving the issue templates for bugs and features, aiming to give us more complete information for the triage process. It can be previewed partially here.

The description for #1927 has been amended to include StackBlitz in the bug template, once it exists.

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@danielbate danielbate added the chore Issue is a chore label Jul 8, 2024
@danielbate danielbate added this to the 0.x mainnet milestone Jul 8, 2024
@danielbate danielbate self-assigned this Jul 8, 2024
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this @danielbate it's definitely an improvement on what we have now.

I know that #1927 is a part of the post-launch milestone but I do wonder if having that functionality would significantly improve the bug reporting process as we would have easily reproducible bugs.

.github/ISSUE_TEMPLATE/1-bug.yaml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/1-bug.yaml Outdated Show resolved Hide resolved
@danielbate
Copy link
Contributor Author

@arboleya given you have resolved the conversation, can this be merged?

@arboleya
Copy link
Member

@danielbate I ran out of ideas for making this easier without removing the fields.

We can test it out and adjust as we go, as/if necessary.

@danielbate
Copy link
Contributor Author

@arboleya sure thing, for now I've also enabled blank issues.

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.4%(+0.04%) 71.53%(-0.12%) 77.32%(+0.02%) 79.53%(+0.04%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 82.31%
(+1.16%)
65.07%
(+1.14%)
82.35%
(+0.54%)
82%
(+1.15%)
🔴 packages/account/src/providers/provider.ts 68.02%
(-0.82%)
62.63%
(-1.19%)
73.49%
(-0.31%)
67.98%
(-0.81%)
🔴 packages/account/src/test-utils/launchNode.ts 98.27%
(+0.01%)
85.24%
(+0.5%)
100%
(+0%)
98.36%
(+0.02%)
🔴 packages/contract/src/contract-factory.ts 58.33%
(-0.29%)
46.42%
(+0.27%)
54.54%
(+0%)
58.33%
(-0.29%)
🔴 packages/contract/src/util.ts 93.75%
(+0.42%)
0%
(+0%)
66.66%
(+0%)
88.88%
(+0.65%)
🔴 packages/create-fuels/src/cli.ts 85.5%
(+0.21%)
37.5%
(-2.5%)
100%
(+0%)
85.5%
(+0.21%)

@danielbate danielbate merged commit 1013aca into master Jul 23, 2024
20 checks passed
@danielbate danielbate deleted the db/chore/issue-templates branch July 23, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider reviewing GH Issue templates
5 participants