Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add testing to create-fuels #2755

Merged
merged 20 commits into from
Jul 19, 2024
Merged

feat: add testing to create-fuels #2755

merged 20 commits into from
Jul 19, 2024

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Jul 11, 2024 •
edited

Summary

Added vitest to the create fuels template with program type testing via launchTestNode. In code documentation to support #2461.

Checklist

  • I added — tests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@danielbate danielbate added the feat Issue is a feature label Jul 11, 2024
@danielbate danielbate added this to the 0.x post-launch milestone Jul 11, 2024
@danielbate danielbate self-assigned this Jul 11, 2024
@danielbate danielbate changed the title Db/feat/create fuels testing feat: add testing to create-fuels Jul 11, 2024
@danielbate danielbate marked this pull request as ready for review July 11, 2024 13:12
petertonysmith94
petertonysmith94 reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest syncing the changes from the template into apps/create-fuels-counter-guide.

Then adding the decrement_counter.test.ts test to create-fuels-counter-guide/test/contract.test.ts.

Otherwise, lovely jurb! 🚀

@arboleya arboleya modified the milestones: 0.x post-launch, 0.x mainnet Jul 15, 2024
@danielbate
Copy link
Contributor Author

I'd suggest syncing the changes from the template into apps/create-fuels-counter-guide.

@petertonysmith94 done 👍🏻

@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 9:23am

@petertonysmith94 petertonysmith94 marked this pull request as draft July 18, 2024 16:58
@petertonysmith94
chore: stabilise testing for create fuels templating (#2799)
690a77e 
* chore: improving functionality for create fuels testing

* chore: added missing `templateName`

* chore: ensure that tests-find detects the comments
@petertonysmith94
Merge branch 'master' into db/feat/create-fuels-testing
25eff54
@petertonysmith94 petertonysmith94 marked this pull request as ready for review July 19, 2024 14:53
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.39%(+0.03%) 71.62%(-0.03%) 77.32%(+0.02%) 79.52%(+0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/create-fuels/src/cli.ts 85.5%
(+0.21%)		 37.5%
(-2.5%)		 100%
(+0%)		 85.5%
(+0.21%)

@arboleya arboleya removed this from the 0.x mainnet milestone Jul 19, 2024
@petertonysmith94 petertonysmith94 merged commit 740f1ae into master Jul 19, 2024
20 checks passed
@petertonysmith94 petertonysmith94 deleted the db/feat/create-fuels-testing branch July 19, 2024 15:28
@fuel-service-user fuel-service-user mentioned this pull request Jul 19, 2024
Merged
@petertonysmith94 petertonysmith94 mentioned this pull request Jul 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@nedsalk nedsalk nedsalk approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@danielbate danielbate

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate launchTestNode into templates
5 participants
@danielbate @arboleya @maschad @petertonysmith94 @nedsalk