Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added missing imports #2770

Merged
merged 7 commits into from
Jul 16, 2024
Merged

chore: added missing imports #2770

merged 7 commits into from
Jul 16, 2024

Conversation

petertonysmith94
Copy link
Contributor

Summary

  • Added missing imports to address the forum post... maybe.

Checklist

  • I added — tests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Jul 15, 2024
@petertonysmith94 petertonysmith94 added this to the 0.x mainnet milestone Jul 15, 2024
@petertonysmith94 petertonysmith94 self-assigned this Jul 15, 2024
@petertonysmith94 petertonysmith94 marked this pull request as ready for review July 15, 2024 08:14
danielbate
danielbate approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be surprised if this resolved that post but the change is still valid 👍🏻

@petertonysmith94
Copy link
Contributor Author

I'd be surprised if this resolved that post but the change is still valid 👍🏻

Also doubtful - a guy can dream though!

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.37%(+0%) 71.65%(+0%) 77.3%(+0%) 79.5%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit 3e9bc26 into master Jul 16, 2024
19 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/add-missing-imports branch July 16, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@maschad maschad maschad approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@petertonysmith94 @arboleya @danielbate @maschad