Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add more comments around the create-fuels template app #2772

Merged
merged 12 commits into from
Jul 19, 2024
Merged

docs: add more comments around the create-fuels template app #2772

merged 12 commits into from
Jul 19, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Jul 15, 2024 •
edited

Summary

This PR adds some helpful comments around the create-fuels template app with an aim to better document the source code for our users.

Checklist

  • I added — tests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@Dhaiwat10 Dhaiwat10 added the docs Requests pertinent to documentation label Jul 15, 2024
@Dhaiwat10 Dhaiwat10 added this to the 0.x mainnet milestone Jul 15, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Jul 15, 2024
@Dhaiwat10 Dhaiwat10 marked this pull request as draft July 15, 2024 08:59
@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review July 15, 2024 09:14
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) July 15, 2024 09:15
maschad
maschad requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor correction

apps/create-fuels-counter-guide/src/app/page.tsx Outdated Show resolved Hide resolved
@danielbate @maschad
chore: update comment
d5c5c09 
Co-authored-by: Chad Nehemiah <[email protected]>
@danielbate danielbate requested a review from maschad July 16, 2024 07:49
maschad
maschad previously approved these changes Jul 16, 2024
View reviewed changes
@vercel Vercel
Copy link

vercel bot commented Jul 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 9:08am

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.36%(-0.01%) 71.65%(+0%) 77.3%(+0%) 79.49%(-0.01%)
Changed Files:

Coverage values did not change👌.

@Dhaiwat10 Dhaiwat10 merged commit f3e89d2 into master Jul 19, 2024
21 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/create-fuels-comments branch July 19, 2024 09:20
@fuel-service-user fuel-service-user mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@maschad maschad maschad approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
docs Requests pertinent to documentation
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging this pull request may close these issues.

create-fuels add more comments to the template
5 participants
@Dhaiwat10 @arboleya @danielbate @maschad @petertonysmith94