Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create-fuels install dependencies by default #2779

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix: create-fuels install dependencies by default #2779

merged 2 commits into from
Jul 17, 2024

Conversation

petertonysmith94
Copy link
Contributor

Summary

  • create-fuels now installs dependencies by default

Checklist

  • I added — tests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Jul 17, 2024
@petertonysmith94 petertonysmith94 added this to the 0.x mainnet milestone Jul 17, 2024
@petertonysmith94 petertonysmith94 self-assigned this Jul 17, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 0:08am

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.37%(+0%) 71.65%(+0%) 77.3%(+0%) 79.5%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 marked this pull request as ready for review July 17, 2024 12:08
@petertonysmith94 petertonysmith94 merged commit 25587d4 into master Jul 17, 2024
26 of 27 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/fix/create-fuels-not-installing branch July 17, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@maschad maschad maschad approved these changes

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging this pull request may close these issues.

create fuels does not automatically install dependencies anymore
4 participants
@petertonysmith94 @arboleya @maschad @Dhaiwat10