-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: consider message on resources cache #2872
Merged
Torres-ssf
merged 34 commits into
master
from
st/fix/unset-cached-resource-for-failed-tx
Aug 9, 2024
Merged
feat!: consider message on resources cache #2872
Torres-ssf
merged 34 commits into
master
from
st/fix/unset-cached-resource-for-failed-tx
Aug 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torres-ssf
changed the title
fix: unset cached resource for failed tx
fix: unset cached resource for failed TX
Aug 2, 2024
Torres-ssf
requested review from
digorithm,
arboleya,
Dhaiwat10,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
August 2, 2024 20:52
arboleya
reviewed
Aug 3, 2024
petertonysmith94
previously approved these changes
Aug 7, 2024
nedsalk
previously approved these changes
Aug 7, 2024
maschad
reviewed
Aug 7, 2024
Co-authored-by: Chad Nehemiah <[email protected]>
nedsalk
approved these changes
Aug 8, 2024
petertonysmith94
approved these changes
Aug 8, 2024
maschad
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚀
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
Message
resources upon transaction submissionSummary
This PR addresses two issues:
1 - Unsetting cached resources if the transaction fails during processing. Previously, UTXO(s) remained cached and unavailable for new transactions until the cache TTL expired, potentially leading to resource unavailability for subsequent transactions.
2- Ensure the resource cache considers Message coins upon transaction submission, not just UTXO(s).
Breaking Changes
The provider option flag
cacheUtxo
was renamed toresourceCacheTTL
Checklist
tests
to prove my changesdocs