Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid re-add fake resources at Account.getTransactionCost #2982

Merged
merged 7 commits into from
Aug 19, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Aug 19, 2024

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf self-assigned this Aug 19, 2024
Copy link
Contributor

github-actions bot commented Aug 19, 2024

This PR is published in NPM with version 0.0.0-pr-2982-20240819224247

@Torres-ssf Torres-ssf changed the title Replicate Logic From Old getTransationCost fix: avoid re-add fake resources at Account.getTransactionCost Aug 19, 2024
@github-actions github-actions bot added the bug Issue is a bug label Aug 19, 2024
@Torres-ssf Torres-ssf marked this pull request as ready for review August 19, 2024 22:42
@Torres-ssf Torres-ssf enabled auto-merge (squash) August 19, 2024 22:44
arboleya
arboleya previously approved these changes Aug 19, 2024
LuizAsFight
LuizAsFight previously approved these changes Aug 19, 2024
helciofranco
helciofranco previously approved these changes Aug 19, 2024
@arboleya arboleya disabled auto-merge August 19, 2024 23:04
@Torres-ssf Torres-ssf enabled auto-merge (squash) August 19, 2024 23:37
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.42%(+0.21%) 71.79%(+0.41%) 77.82%(+0.45%) 79.55%(+0.21%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/AbiCoder.ts 100%
(+25%)
0%
(+0%)
100%
(+33.34%)
100%
(+25%)
🔴 packages/abi-coder/src/FunctionFragment.ts 63.15%
(+0.99%)
37.5%
(+0%)
69.23%
(+2.57%)
63.41%
(+1.88%)
🔴 packages/abi-coder/src/Interface.ts 76%
(+4.58%)
63.63%
(+0%)
75%
(+2.28%)
75%
(+4.17%)
🔴 packages/abi-coder/src/encoding/strategies/getCoderV1.ts 91.83%
(+0.17%)
88.57%
(+1.48%)
100%
(+0%)
92%
(+0.17%)
🔴 packages/abi-coder/src/utils/constants.ts 97.56%
(+0.06%)
100%
(+0%)
0%
(+0%)
97.56%
(+0.06%)
🔴 ✨ packages/abi-coder/src/utils/transpile-abi.ts 97.36%
(+97.36%)
87.5%
(+87.5%)
94.11%
(+94.11%)
95.45%
(+95.45%)
packages/abi-typegen/src/templates/utils/formatEnums.ts 100%
(+0%)
100%
(+50%)
100%
(+0%)
100%
(+0%)
packages/abi-typegen/src/templates/utils/formatStructs.ts 100%
(+0%)
100%
(+50%)
100%
(+0%)
100%
(+0%)
🔴 ✨ packages/abi-typegen/src/utils/transpile-abi.ts 100%
(+100%)
95.83%
(+95.83%)
94.11%
(+94.11%)
97.72%
(+97.72%)
🔴 packages/account/src/account.ts 82.82%
(-1.18%)
64.38%
(-3.31%)
86.84%
(+1.55%)
82.53%
(-1.13%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.48%
(+0%)
79.71%
(+1.45%)
84%
(+0%)
88.73%
(+0%)

@Torres-ssf Torres-ssf merged commit 2a8cb38 into master Aug 19, 2024
20 checks passed
@Torres-ssf Torres-ssf deleted the st/fix/max-fee-diff branch August 19, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid Re-Adding Resources When Estimate TX At Account.getTransactionCost
5 participants