Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make create-fuels template app responsive #3011

Merged
merged 10 commits into from
Aug 29, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Aug 22, 2024

Release notes

In this release, we:

  • Made the create-fuels template app mobile-friendly

Summary

This PR adds a responsive navbar to the create-fuels template to ensure that it is usable on mobile devices as well.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this impact the UI integration tests at all?

@Dhaiwat10
Copy link
Member Author

@danielbate I don't think so 🤔 Is there a way to run them here?

@petertonysmith94
Copy link
Contributor

@Dhaiwat10 I have been releasing to NPM then running the tests against the PR - as seen here.

danielbate
danielbate previously approved these changes Aug 28, 2024
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 0:36am
fuels-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 0:36am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Aug 29, 2024 0:36am

Torres-ssf
Torres-ssf previously approved these changes Aug 28, 2024
Copy link
Contributor

This PR is published in NPM with version 0.0.0-pr-3011-20240828152541

danielbate
danielbate previously approved these changes Aug 28, 2024
maschad
maschad previously approved these changes Aug 28, 2024
arboleya
arboleya previously approved these changes Aug 29, 2024
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is demoable in the preview 🎉 Need to get it working against a testnet contract but WIP. Great work Dhai.

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.42%(+0%) 71.82%(-0.04%) 77.7%(+0%) 79.55%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.48%
(+0%)
78.26%
(-1.45%)
84%
(+0%)
88.73%
(+0%)

@Dhaiwat10 Dhaiwat10 merged commit e04947a into master Aug 29, 2024
23 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/create-fuels-mobile-friendly branch August 29, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure create-fuels template app is mobile-friendly
6 participants