-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support message types #3016
base: master
Are you sure you want to change the base?
Conversation
({ type }) => ReceiptType.MessageOut === type | ||
) as ReceiptMessageOut; | ||
|
||
expect(messageOutReceipt.recipient).toBe(recipient.address.toB256()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that the data
field of the MessageOut
receipt is tied to its respective entry in the messageTypes
array of the abi. It seems to me that part of supporting them, as the linked issue #2347 requires, would be to have this data decoded in these receipts.
expect(messageOutReceipt.data).toStrictEqual(msg_data);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Co-authored-by: Nedim Salkić <[email protected]>
MessageType.messageId
property
Coverage Report:
Changed Files:
|
messagesTypes
for the ABI #2347Summary
This PR corrects the JSON ABI property name by renaming
messagesTypes.message_id
tomessagesTypes.messageId
, which is the correct name within a generated JSO ABI. Theexhaustive-example
contract has also been updated to include a method that generates entries for themessagesTypes
array within its JSON ABI. A new test case has also been added to validate that the property is generated correctly.Checklist