Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: made chainConfig files match testnet configuration #3020

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Aug 23, 2024

Summary

This PR updates the chainConfig files in our tests to align with the latest testnet upgrade, ensuring consistency across the testing environment. The gasCosts new values resulted in expressively reduced transaction fees, requiring some fine-tuning of a few tests.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf added the chore Issue is a chore label Aug 23, 2024
@Torres-ssf Torres-ssf self-assigned this Aug 23, 2024
@Torres-ssf Torres-ssf changed the title chore: update chain config to match testnet configuration chore: made chainConfig files match testnet configuration Aug 23, 2024
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Torres-ssf , I assume you are using this config just a few questions about the discrepancies

.fuel-core/configs/chainConfig.json Show resolved Hide resolved
.fuel-core/configs/chainConfig.json Show resolved Hide resolved
.fuel-core/configs/chainConfig.json Show resolved Hide resolved
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @Torres-ssf.

I think it'd be worth documenting this process - which could then serve as a basis of automating down the line.

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ❌ Failed (Inspect) Aug 27, 2024 1:18am
create-fuels-template-preview ❌ Failed (Inspect) Aug 27, 2024 1:18am

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.42%(+0%) 71.82%(+0.03%) 77.7%(-0.14%) 79.55%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/utils/transpile-abi.ts 100%
(+2.64%)
91.66%
(+4.16%)
94.11%
(+0%)
97.72%
(+2.27%)
🔴 packages/account/src/connectors/fuel.ts 95.39%
(-1.16%)
90.66%
(+1.33%)
88.88%
(-6.35%)
95.56%
(-1.12%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.48%
(+0%)
78.26%
(-1.45%)
84%
(+0%)
88.73%
(+0%)

@Torres-ssf Torres-ssf merged commit 986a247 into master Aug 27, 2024
21 of 23 checks passed
@Torres-ssf Torres-ssf deleted the st/fix/update-gas-costs branch August 27, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants