Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove TS errors from some tests #3026

Merged
merged 12 commits into from
Aug 26, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Aug 23, 2024

Summary

There are way too many TS errors in the SDK's test files. This PR aims to cut down that number.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵️‍♂️ 🧹 🚢

Question: A bunch of these should have been caught by lint, right?

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.42%(+0%) 71.82%(+0.03%) 77.7%(-0.14%) 79.55%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/utils/transpile-abi.ts 100%
(+2.64%)
91.66%
(+4.16%)
94.11%
(+0%)
97.72%
(+2.27%)
🔴 packages/account/src/connectors/fuel.ts 95.39%
(-1.16%)
90.66%
(+1.33%)
88.88%
(-6.35%)
95.56%
(-1.12%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.48%
(+0%)
78.26%
(-1.45%)
84%
(+0%)
88.73%
(+0%)

@Torres-ssf
Copy link
Contributor Author

Torres-ssf commented Aug 23, 2024

🕵️‍♂️ 🧹 🚢

Question: A bunch of these should have been caught by lint, right?

@arboleya You're right it should, but it appears that test files are ignored by the lintscript

@Torres-ssf Torres-ssf merged commit 682d62e into master Aug 26, 2024
20 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/remove-ts-errors-from-tests branch August 26, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants