Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added missing dependencies for templates #3035

Merged
merged 6 commits into from
Aug 27, 2024
Merged

fix: added missing dependencies for templates #3035

merged 6 commits into from
Aug 27, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Aug 26, 2024 •
edited
Loading

Summary

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Aug 26, 2024
@petertonysmith94 petertonysmith94 self-assigned this Aug 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024 •
edited
Loading

This PR is published in NPM with version 0.0.0-pr-3035-20240826125544

@petertonysmith94 petertonysmith94 marked this pull request as ready for review August 26, 2024 13:03
@petertonysmith94 petertonysmith94 mentioned this pull request Aug 26, 2024
Open
arboleya
arboleya previously approved these changes Aug 26, 2024
View reviewed changes
maschad
maschad previously approved these changes Aug 27, 2024
View reviewed changes
danielbate
danielbate previously approved these changes Aug 27, 2024
View reviewed changes
@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ❌ Failed (Inspect) Aug 27, 2024 7:43am
create-fuels-template-preview ❌ Failed (Inspect) Aug 27, 2024 7:43am

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.42%(+0%) 71.82%(+0.03%) 77.7%(-0.14%) 79.55%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/abi-coder/src/utils/transpile-abi.ts 100%
(+2.64%)		 91.66%
(+4.16%)		 94.11%
(+0%)		 97.72%
(+2.27%)
🔴 packages/account/src/connectors/fuel.ts 95.39%
(-1.16%)		 90.66%
(+1.33%)		 88.88%
(-6.35%)		 95.56%
(-1.12%)
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.48%
(+0%)		 78.26%
(-1.45%)		 84%
(+0%)		 88.73%
(+0%)

@petertonysmith94 petertonysmith94 enabled auto-merge (squash) August 27, 2024 08:29
@petertonysmith94 petertonysmith94 merged commit 71331d7 into master Aug 27, 2024
21 of 23 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/fix/integration-test branch August 27, 2024 16:43
@petertonysmith94 petertonysmith94 changed the title fix: integration test fix: added missing dependencies for templates Aug 27, 2024
This was referenced Aug 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@maschad maschad maschad approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix integration / UI tests for create-fuels
5 participants
@petertonysmith94 @arboleya @danielbate @maschad @Torres-ssf