Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: embed testnet faucet in create-fuels template #3036

Merged
merged 4 commits into from
Aug 29, 2024
Merged

feat: embed testnet faucet in create-fuels template #3036

merged 4 commits into from
Aug 29, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Aug 26, 2024 •
edited
Loading

Release notes

In this release, we:

  • Added an embedded testnet faucet into the create-fuels template app

Summary

This PR lets users use the testnet faucet via an embedded iframe from the template app, without having to leave the app just to get faucet funds.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dhaiwat10 Dhaiwat10 added the feat Issue is a feature label Aug 26, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Aug 26, 2024
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) August 26, 2024 14:07
petertonysmith94
petertonysmith94 reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this affect the UI tests?

templates/nextjs/src/components/Layout.tsx Show resolved Hide resolved
templates/nextjs/src/app/faucet/page.tsx Outdated Show resolved Hide resolved
templates/vite/src/routes/faucet.lazy.tsx Outdated Show resolved Hide resolved
@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 2:29am
fuels-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 2:29am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Aug 29, 2024 2:29am

@Dhaiwat10
Copy link
Member Author

@petertonysmith94 this shouldn't affect the UI integration tests as I believe those are run in the local environment whereas the testnet faucet only shows up in the testnet environment

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.42%(+0%) 71.86%(+0%) 77.7%(+0%) 79.55%(+0%)
Changed Files:

Coverage values did not change👌.

@Dhaiwat10 Dhaiwat10 merged commit 08aa4ae into master Aug 29, 2024
23 checks passed
@Dhaiwat10 Dhaiwat10 deleted the dp/faucet-iframe branch August 29, 2024 08:56
@fuel-service-user fuel-service-user mentioned this pull request Aug 29, 2024
Merged
This was referenced Aug 29, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@maschad maschad maschad approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate embedded testnet faucet via iframe in create fuels template
5 participants
@Dhaiwat10 @arboleya @danielbate @maschad @petertonysmith94