Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: handling UTXO error in transaction re-submissions #3050

Merged
merged 18 commits into from
Aug 30, 2024
Merged

docs: handling UTXO error in transaction re-submissions #3050

merged 18 commits into from
Aug 30, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Aug 28, 2024 •
edited
Loading

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf added the docs Requests pertinent to documentation label Aug 28, 2024
@Torres-ssf Torres-ssf self-assigned this Aug 28, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 1:51pm
fuels-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 1:51pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 1:51pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Aug 30, 2024 1:51pm

@Torres-ssf Torres-ssf marked this pull request as ready for review August 28, 2024 20:22
arboleya
arboleya previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Left a couple of nits.

apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md Outdated Show resolved Hide resolved
apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md Outdated Show resolved Hide resolved
apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md Outdated Show resolved Hide resolved
apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md Outdated Show resolved Hide resolved
apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md Outdated Show resolved Hide resolved
apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md Outdated Show resolved Hide resolved
apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md Outdated Show resolved Hide resolved
apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md Outdated Show resolved Hide resolved
apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md Outdated Show resolved Hide resolved
Torres-ssf and others added 7 commits August 30, 2024 07:44
@Torres-ssf @arboleya
Update apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md
9f9b7ec 
Co-authored-by: Anderson Arboleya <[email protected]>
@Torres-ssf @arboleya
Update apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md
a6e1191 
Co-authored-by: Anderson Arboleya <[email protected]>
@Torres-ssf @arboleya
Update apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md
91c8ce7 
Co-authored-by: Anderson Arboleya <[email protected]>
@Torres-ssf @arboleya
Update apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md
ccb4f57 
Co-authored-by: Anderson Arboleya <[email protected]>
@Torres-ssf @arboleya
Update apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md
9bf612e 
Co-authored-by: Anderson Arboleya <[email protected]>
@Torres-ssf @arboleya
Update apps/docs/src/guide/cookbook/resubmitting-failed-transactions.md
fb7bca8 
Co-authored-by: Anderson Arboleya <[email protected]>
@Torres-ssf @petertonysmith94
Update apps/docs-snippets/src/guide/cookbook/resubmitting-failed-tran…
ba2877e 
…sactions.test.ts

Co-authored-by: Peter Smith <[email protected]>
arboleya
arboleya approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are excellent docs regarding this issue.

Thanks for the detailed explanations. 👌

danielbate
danielbate approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯

maschad
maschad approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@Torres-ssf Torres-ssf enabled auto-merge (squash) August 30, 2024 13:47
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.55%(+0%) 71.91%(+0%) 78%(+0%) 79.68%(+0%)
Changed Files:

Coverage values did not change👌.

@Torres-ssf Torres-ssf merged commit 2ffaaf7 into master Aug 30, 2024
23 checks passed
@Torres-ssf Torres-ssf deleted the st/docs/document-tx-re-submission-failure branch August 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@danielbate danielbate danielbate approved these changes

@maschad maschad maschad approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
docs Requests pertinent to documentation
Projects
None yet
Milestone
No milestone
5 participants
@Torres-ssf @arboleya @danielbate @maschad @petertonysmith94