Improved trait coherence checking #6844
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements improved trait coherence checking,
The idea of trait coherence is that, given a trait and some set of types for its type parameters, there should be exactly one impl that applies.
To check for coherence, the compiler does two separate but related checks:
Right now this implements overlap checks for traits and inherent impls, without yet taking into account for trait constraints.
Checklist
Breaking*
orNew Feature
labels where relevant.