Allow decimal/binary/octal u256 literals#7043
Merged
IGI-111 merged 4 commits intoFuelLabs:masterfrom Apr 2, 2025
Merged
Conversation
This was referenced Mar 27, 2025
Contributor
|
looks like the one CI issue is unrelated to this PR @JoshuaBatty any idea why that utils test is failing? |
Contributor
|
Looks like it's just flaky |
xunilrj
reviewed
Mar 28, 2025
xunilrj
approved these changes
Apr 2, 2025
IGI-111
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the constraint on
u256literals being only expressed in hexadecimal.The constraint has been removed and the code slightly refactored to remove the unnecessary
radixvariable in thelex_int_litfunction intoken.rs.The corresponding error
LexErrorKind::U256NotInHexhas been removed from the codebasen as well as theshould_failtest looking to raise this error.The u256 testing suite has been augmented with additional tests to make sure we can express u256 literals in decimal, binary and octal.
Closes #5456
Checklist
Breaking*orNew Featurelabels where relevant.