Skip to content

TypeArgument as enum to support const generics #7052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Apr 1, 2025

Description

Continuation of #7044.
This PR converts TypeArgument to an enum to support "const generic" in the future. It is being done separately because it changes a lot of files.

No change in behaviour is expected.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj self-assigned this Apr 1, 2025
@xunilrj xunilrj temporarily deployed to fuel-sway-bot April 1, 2025 00:03 — with GitHub Actions Inactive
@xunilrj xunilrj temporarily deployed to fuel-sway-bot April 1, 2025 00:20 — with GitHub Actions Inactive
Copy link

codspeed-hq bot commented Apr 1, 2025

CodSpeed Performance Report

Merging #7052 will not alter performance

Comparing xunilrj/type-argument-as-enum (1bf1e9e) with master (4eb0705)

Summary

✅ 22 untouched benchmarks

@xunilrj xunilrj marked this pull request as ready for review April 1, 2025 10:02
@xunilrj xunilrj requested review from a team as code owners April 1, 2025 10:02
@xunilrj xunilrj merged commit 34aa19c into master Apr 1, 2025
40 checks passed
@xunilrj xunilrj deleted the xunilrj/type-argument-as-enum branch April 1, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants