Small bugfix + Conda environment change for MacOS #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
When trying out the example, I noticed that when I didn't specify
savename
in the arguments it gave me the following error:Small bugfix
The issue was that
run_tapioca.py
was trying to access an attribute of theNamespace
objectargs
. Sincesavename
isn't specified, there is no attributeargs.savename
hence theAttributeError
. To resolve this I converted args to a dictionary and just check for the key"savename"
. This seems to have resolved the issue and I could run the following without any errorsConda environment
I wasn't able to build the conda environment from
tapioca_env_mac.yml
and I suspect it's because the build versions were specific to Intel-based Macs. I don't have an Intel-based Mac to test this hypothesis so I can't be 100% sure. However, I usedconda-tree
to find the minimal set of packages needed to maketapioca_env_mac.yml
more cross-compatible. I kept the package versions but not the build versions and that seems to have resolved the issue. I tested the same command and it works:I noticed some small numerical deviations when making these changes, but they seemed on the order of 1e-4 across the whole output. To test the magnitude of difference I did the following (pre is the example data provided and post represents the results after my changes):
I suspect this is run to run variance, but if it seems unusual, I'm happy to investigate. Also, If someone could confirm that these changes are backwards-compatible and don't have side effects, that would be awesome. I figured using the example data was a good way to test, but I'm not sure if there's other more robust tests.