Skip to content

The Freelancer's Hall: Freifechters [PORT]#64

Open
atomicplan666 wants to merge 11 commits intoFurnace-Chronicles:mainfrom
atomicplan666:fighting-styles
Open

The Freelancer's Hall: Freifechters [PORT]#64
atomicplan666 wants to merge 11 commits intoFurnace-Chronicles:mainfrom
atomicplan666:fighting-styles

Conversation

@atomicplan666
Copy link
Contributor

About The Pull Request

ports Rotwood-Vale/Ratwood-2.0/pull/755

Testing Evidence

compiles fine

Why It's Good For The Game

adds new fighting styles and cool sounds and sprites

- added missing shit for shit
- remove color thing when right click fencing gambeson
- sheathe icons so sword doesn't disappear when sheathed (due to missing the "elongsword" sheathe_icon.
@atomicplan666 atomicplan666 added the Test Merge This PR is ready to be test merged. label Feb 11, 2026
@atomicplan666
Copy link
Contributor Author

image

@atomicplan666
Copy link
Contributor Author

image

..()
update_icon()

// Can't figure out why this shit is spawning invisible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that is still happening?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that is still happening?

nope

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comment

if((used_intent.blade_class == BCLASS_PUNCH))
accuracy_bonus += 5
if(used_intent.blade_class == BCLASS_HALFSWORD)
chance2hit += 21 //Double that of stab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all of this be a switch statement? If there can only be one blade_class for used_intent, then yes it should be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all of this be a switch statement? If there can only be one blade_class for used_intent, then yes it should be.

nope

return
user.remove_status_effect(/datum/status_effect/buff/psydonic_endurance)
return
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what the armor_filtering component is doing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what the armor_filtering component is doing?

nope

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I'll take a deeper look when I have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Balance Code Sound Sprite Test Merge This PR is ready to be test merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants